[FFmpeg-devel] [PATCH]lavfi/subtitles: Fix subtitles default for ass option shaping

Hendrik Leppkes h.leppkes at gmail.com
Sun Jun 21 19:27:07 EEST 2020


On Sun, Jun 21, 2020 at 6:05 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
> Am So., 21. Juni 2020 um 15:52 Uhr schrieb Hendrik Leppkes
> <h.leppkes at gmail.com>:
> >
> > On Sun, Jun 21, 2020 at 1:41 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > >
> > > Am So., 21. Juni 2020 um 12:04 Uhr schrieb Paul B Mahol <onemda at gmail.com>:
> > > >
> > > > NAK.
> > >
> > > Would you like to elaborate?
> >
> > It does seem a bit weird to set the default like this. Shouldn't the
> > default come from the options table, which seems to default to -1? And
> > if that doesn't work - why not?
>
> As I tried to explain in the commit message, the option does not
> exist for the subtitles filter.
>

The commit message does not really explain. If you add that, I reckon its fine.

- Hendrik


More information about the ffmpeg-devel mailing list