[FFmpeg-devel] [PATCH] avformat/isom: enable extended language for mov

[Yongle Lin]

Hi Derek,

Thank you for your email. I'm sorry for the misunderstanding.

Basically, ISO language can be used only for user data text in a QuickTime
file. All other elements including text tracks must be
specified using Macintosh language codes. But it's valid to have ISO codes
for text tracks of mov. So this patch allows ISO 639 codes for mov files.
For example, "-metadata language:s:0 language=deu" currently drops the
language information. I also added a sample FATE test you can check.

I see it's inappropriate to say "extended", I will correct the description
of the patch and resent it to you.

Best,
Yongle

On Thu, Jun 18, 2020 at 3:55 AM Derek Buitenhuis <derek.buitenhuis at gmail.com>
wrote:

> On 12/06/2020 00:35, Yongle Lin wrote:
> > Allow extended language codes using ISO designation for text tracks in
> mov format when strictness is set to experimental
> > ---
> > This patch includes a support for mov format to extend language codes
> using ISO designation for text tracks(
> https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap4/qtff4.html#//apple_ref/doc/uid/TP40000939-CH206-27005)
> and a FATE test associates with it.
> >
> >  libavformat/isom.c               | 9 +++++++--
> >  libavformat/isom.h               | 2 +-
> >  libavformat/movenc.c             | 6 +++---
> >  tests/fate/mov.mak               | 3 +++
> >  tests/ref/fate/mov-extended-lang | 4 ++++
> >  5 files changed, 18 insertions(+), 6 deletions(-)
> >  create mode 100644 tests/ref/fate/mov-extended-lang
>
> The document you've linked seems to imply you should be using the elng
> atom?
>
> Perhaps I have misread, or lack context here...
>
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".