[FFmpeg-devel] [PATCH v6] avcodec/mpeg12enc: support mpeg2 encoder const profile

lance.lmwang at gmail.com lance.lmwang at gmail.com
Sat Jun 20 01:44:13 EEST 2020


On Fri, Jun 19, 2020 at 06:50:03PM +0200, Carl Eugen Hoyos wrote:
> Am Sa., 30. Mai 2020 um 15:29 Uhr schrieb <lance.lmwang at gmail.com>:
> >
> > From: Limin Wang <lance.lmwang at gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> > ---
> >  doc/encoders.texi      | 14 ++++++++++++++
> >  libavcodec/mpeg12enc.c |  2 ++
> >  libavcodec/profiles.h  |  8 ++++++++
> >  3 files changed, 24 insertions(+)
> >
> > diff --git a/doc/encoders.texi b/doc/encoders.texi
> > index 954f0f6..1331b79 100644
> > --- a/doc/encoders.texi
> > +++ b/doc/encoders.texi
> > @@ -2740,6 +2740,20 @@ MPEG-2 video encoder.
> >  @subsection Options
> >
> >  @table @option
> > + at item profile @var{integer}
> > +Select the mpeg2 profile to encode:
> > +
> > + at table @samp
> > + at item 422
> > + at item main
> > + at item ss
> > +Spatially Scalable
> > + at item snr
> > +SNR Scalable
> > + at item high
> > + at item simple
> > + at end table
> 
> Above looks wrong (as reported on the user mailing list):
> high and main have to be swapped, no?

User can't assume the integer value by the order, it's const 
string. I recall ffmpeg -h full can give the detail integer,
now it's missing for the profile options, what's the problem?

But I'll fix the order to avoid such confusing.

> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang


More information about the ffmpeg-devel mailing list