[FFmpeg-devel] [PATCH] avutil: Add NV61 pixel format and enable IO support for NV16 and NV61 pixel formats

Alexander Strasser eclipse7 at gmx.net
Fri Jun 19 22:58:03 EEST 2020


On 2020-06-19 20:41 +0200, Carl Eugen Hoyos wrote:
> Am Fr., 19. Juni 2020 um 20:33 Uhr schrieb Cristian Bicheru
> <c.bicheru0 at gmail.com>:
> >
> > On Fri, Jun 19, 2020 at 12:53 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > >
> > > Am Fr., 19. Juni 2020 um 18:42 Uhr schrieb <c.bicheru0 at gmail.com>:
> > > >
> > > > From: Cristian Bicheru <c.bicheru0 at gmail.com>
> > > >
> > > > NV16 and NV61 are interleaved 4:2:2 8-bit formats. There was some internal
> > > > NV16 support prior to this patch but the pixel format was not publicly accessible.
>
> > > Please explain (as thorough as possible) why the new pix_fmt is necessay.
> >
> > I mainly added the new format for completion
>
> This does not sound like a good reason to add complexity.
>
> If you find a camera that only supports NV61, I would say
> we should reconsider.

I guess NV61 is not super important, but it's kind of an interesting
case to use for reasoning about if additional pixel formats may be
added to the code base or not.

For example "If you find a camera that only supports NV61" seems a bit
to narrow as a guideline. I think if there is equipement that supports
both variants NV16 and NV61, that could be enough to support NV61 too.

One could also argue adding a well defined pixel format should be fine
especially if it is easy. In this case it is a simple and low complexity
change, as we already support NV16 anyway.

How do others think about adding support for more pixel formats?


  Alexander


More information about the ffmpeg-devel mailing list