[FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

[Michael Niedermayer]

On Tue, Jun 16, 2020 at 02:05:04PM +0200, Tomas Härdin wrote:
> mån 2020-06-15 klockan 21:45 +0200 skrev Marton Balint:
> > 
> > On Mon, 15 Jun 2020, Tomas Härdin wrote:
> > 
> > > sön 2020-06-14 klockan 20:19 +0200 skrev Marton Balint:
> > > > On Sun, 14 Jun 2020, Michael Niedermayer wrote:
> > > > 
> > > > > Alternatively we could free the already allocated element
> > > > 
> > > > Yeah, I kind of prefer that, we potentially allow non-string values to 
> > > > occur multiple times, so I'd say let's allow string values as well, even 
> > > > if that is not common. (I am not sure if it is strictly invalid or just 
> > > > uncommon).
> > > 
> > > Are there files in the wild that do this? Being stricter is often the
> > > better option when it comes to MXF. A muxer that outputs metadata more
> > > than once might be doing something wrong.
> > 
> > I am not sure, but I wanted to be safe rather than sorry, because it is 
> > not unusual in MXF to repeat certain metadata in the footer partition 
> > which is already present in the header, and I did not want to take the 
> > risk of rejecting a valid file.
> 
> True, that is not unheard of. Maybe we could warn if the strings don't
> match?

such a warning seem like a good idea to me

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200616/6b97ff14/attachment.sig>