[FFmpeg-devel] [PATCH 14/26] avformat/pjsdec: Fix memleak upon read header failure
Andreas Rheinhardt
andreas.rheinhardt at gmail.com
Mon Jun 15 01:36:44 EEST 2020
The already parsed subtitles (contained in an FFDemuxSubtitlesQueue)
would leak if an error happened upon reading a subsequent subtitle.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
libavformat/pjsdec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/pjsdec.c b/libavformat/pjsdec.c
index 8a5cc04f84..e30c23d830 100644
--- a/libavformat/pjsdec.c
+++ b/libavformat/pjsdec.c
@@ -94,8 +94,10 @@ static int pjs_read_header(AVFormatContext *s)
p[strcspn(p, "\"")] = 0;
sub = ff_subtitles_queue_insert(&pjs->q, p, strlen(p), 0);
- if (!sub)
+ if (!sub) {
+ ff_subtitles_queue_clean(&pjs->q);
return AVERROR(ENOMEM);
+ }
sub->pos = pos;
sub->pts = pts_start;
sub->duration = duration;
--
2.20.1
More information about the ffmpeg-devel
mailing list