[FFmpeg-devel] [PATCH v7 2/3] avdevice/lavfi: support the dumpgraph with options

[Marton Balint]

On Mon, 8 Jun 2020, Nicolas George wrote:

> Marton Balint (12020-06-05):
>> I think it always depended on the fallout, we were never blindly strict
>> about this.
>
> I agree. And in this case, this option is quite obscure, and the
> function behind it even more.
>
>> I suggested the separate option for the options because otherwise you can't
>> do dumpgraph without options specified, so you cant make the code call
>> avfilter_dump_graph(graph, NULL).
>
> We can avfilter_dump_graph(graph, ""), which is equivalent enough.

I am still uneasy about this, but fine.

Regards,
Marton

>
>> "1" as a special string might be OK until some deprecation period but not
>> for all eternity if the options string wants to be an options list and if it
>> must be parseable as an AVDictionary. That would be the same inconsistency
>> which we tried to avoid all over the codebase. E.g. this option looks like a
>> dictionary, except "1" is also accepted...
>
> We are talking about
>
> 	if (options[0] == '1' && !options[1])
> 	    options = "";
>
> at the beginning of an obscure function, not documented, only there to
> avoid breaking existing scripts. If that stays for all eternity, we can
> live with that, I think.