[FFmpeg-devel] [RFC PATCH] libavcodec/libopenjpeg: pix fmt selection change

Michael Bradshaw mjbshaw at google.com
Thu Jun 11 19:11:00 EEST 2020


On Thu, Jun 11, 2020 at 9:42 AM Gautam Ramakrishnan <gautamramk at gmail.com>
wrote:

> Got it. In that case we can safely ignore the patch to fix libopenjpeg.
> However, p1_03.j2k is one of the 2 files to have ppm marker. How could I
> validate a patch to add ppm marker? I need something to cross validate.
> Any suggestions for that?


Does the other file with a ppm marker have a sane pixel format? If not the
only the only way I can think of to test this is to hack ffmpeg to remap
the planes in libopenjpegdec.c (e.g., remap them to yuva format). You can
use that for initial validation but it'll have to be reverted when
committing/pushing.

Long-term I'm not sure how one would regression test this without having a
different file with a sane pixel format. I'm not sure how feasible it is to
hack p1_03.j2k to remove a plane while retaining the ppm marker or perhaps
hacking opj_compress to add a ppm marker to a new test file.


More information about the ffmpeg-devel mailing list