[FFmpeg-devel] [PATCH v10 3/4] avcodec/hevc_sei: add support for user data unregistered SEI message

[Marton Balint]

On Wed, 10 Jun 2020, lance.lmwang at gmail.com wrote:

> From: Limin Wang <lance.lmwang at gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
> libavfilter/vf_showinfo.c | 37 +++++++++++++++++++++++++++++++++++++

Commit subject is wrong.

> 1 file changed, 37 insertions(+)
>
> diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
> index 5d4aee4..9eaf8ff 100644
> --- a/libavfilter/vf_showinfo.c
> +++ b/libavfilter/vf_showinfo.c
> @@ -23,6 +23,7 @@
>  */
> 
> #include <inttypes.h>
> +#include <ctype.h>

Use av_isgraph() instead, ctype is locale dependant.

Regards,
Marton

> 
> #include "libavutil/bswap.h"
> #include "libavutil/adler32.h"
> @@ -190,6 +191,39 @@ static void dump_video_enc_params(AVFilterContext *ctx, AVFrameSideData *sd)
>         av_log(ctx, AV_LOG_INFO, "%u blocks; ", par->nb_blocks);
> }
> 
> +static int string_is_print(const uint8_t *str)
> +{
> +    while (isprint(*str)) str++;
> +    return !*str;
> +}
> +
> +static void dump_sei_unregistered_metadata(AVFilterContext *ctx, AVFrameSideData *sd)
> +{
> +    const int uuid_size = 16;
> +    uint8_t *user_data = sd->data;
> +
> +    if (sd->size < uuid_size) {
> +        av_log(ctx, AV_LOG_ERROR, "invalid data(%d < UUID(%d-bytes))", sd->size, uuid_size);
> +        return;
> +    }
> +
> +    av_log(ctx, AV_LOG_INFO, "User Data Unregistered:\n");
> +    av_log(ctx, AV_LOG_INFO, "UUID=");
> +    for (int i = 0; i < uuid_size; i++) {
> +        av_log(ctx, AV_LOG_INFO, "%02x", user_data[i]);
> +        if (i == 3 || i == 5 || i == 7 || i == 9)
> +            av_log(ctx, AV_LOG_INFO, "-");
> +    }
> +    av_log(ctx, AV_LOG_INFO, "\n");
> +
> +    user_data += uuid_size;
> +    /* Only print the user data details if it's string */
> +    if (string_is_print(user_data)) {
> +        av_log(ctx, AV_LOG_INFO, "User Data=");
> +        av_log(ctx, AV_LOG_INFO, "%s", user_data);
> +    }
> +}
> +
> static void dump_color_property(AVFilterContext *ctx, AVFrame *frame)
> {
>     const char *color_range_str     = av_color_range_name(frame->color_range);
> @@ -375,6 +409,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
>         case AV_FRAME_DATA_VIDEO_ENC_PARAMS:
>             dump_video_enc_params(ctx, sd);
>             break;
> +        case AV_FRAME_DATA_SEI_UNREGISTERED:
> +            dump_sei_unregistered_metadata(ctx, sd);
> +            break;
>         default:
>             av_log(ctx, AV_LOG_WARNING, "unknown side data type %d (%d bytes)",
>                    sd->type, sd->size);
> -- 
> 1.8.3.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".