[FFmpeg-devel] [PATCH] avfilter/f_metadata: use AVBPrint API to remove buf size limitation

[Nicolas George]

lance.lmwang at gmail.com (12020-06-08):
> For the print_file is void, so I haven't considered to add error
> check, can we just print one error message if av_bprint_is_complete
> checking failed?

Assume the log goes to /dev/null. If there is an error, especially if
there is a risk of data loss or data corruption, an error return is
necessary. If it requires changing the type of a function, so be it.

But you can do better than using BPrint: the existing code writes into a
buffer then writes the buffer to avio, even though we have
avio_printf().

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200608/c1b0cf4a/attachment.sig>