[FFmpeg-devel] [PATCH] prompeg_write() must report data all was written

[Michael Niedermayer]

On Mon, Jun 08, 2020 at 04:56:04PM +0800, mypopy at gmail.com wrote:
> On Tue, Apr 2, 2019 at 5:20 AM Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> >
> > On Sun, Mar 31, 2019 at 02:32:34AM +0100, David Holroyd wrote:
> > > Previously, prompeg_write() would only report to caller that bytes we
> > > written when a FEC packet was actually created.  Not all RTP packets are
> > > expected to generate a FEC packet however, so this behavior was causing
> > > avio to retry writing the RTP packet, eventually forcing the FEC state
> > > machine to send a FEC packet erroneously (and so breaking out of the
> > > retry loop).
> > >
> > > This was resulting in incorrect FEC data being generated, and far too
> > > many FEC packets to be sent (~100% FEC overhead).
> > > ---
> > >  libavformat/prompeg.c | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > this patch doesnt seem to apply automatically with git am
> >
> > also no fate test changes, which indicates that this code is not tested.
> > I think it would be rather useful if there was a test that covers this,
> > otherwise any future change to thsís code could break it with the person
> > noticing
> >
> > thanks
> It's about issue http://trac.ffmpeg.org/ticket/7863, and I can confirm
> this fix is working (with wireshark), can we merge this patch first? I
> will add the FATE testcase.

as the patch did not apply with git am, no it cannot be applied obviously

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200608/20bc753a/attachment.sig>