[FFmpeg-devel] [RFC PATCH 1/2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

[Michael Niedermayer]

On Fri, Jun 05, 2020 at 09:54:49PM +0530, Gautam Ramakrishnan wrote:
> On Fri, Jun 5, 2020 at 8:23 AM Gautam Ramakrishnan <gautamramk at gmail.com> wrote:
> >
> > On Fri, Jun 5, 2020 at 3:21 AM Michael Niedermayer
> > <michael at niedermayer.cc> wrote:
> > >
> > > On Thu, Jun 04, 2020 at 01:24:42PM +0530, gautamramk at gmail.com wrote:
> > > > From: Gautam Ramakrishnan <gautamramk at gmail.com>
> > > >
> > > > I have attempted to write a JPEG2000 Parser. Have tested
> > > > by generating a file containing 14 frames, as mentioned
> > > > by Micheal. Have also tried testing with various packet
> > > > sizes by setting -frame_size option.
> > > > ---
> > > >  libavcodec/Makefile          |   1 +
> > > >  libavcodec/jpeg2000_parser.c | 190 +++++++++++++++++++++++++++++++++++
> > > >  libavcodec/parsers.c         |   1 +
> > > >  3 files changed, 192 insertions(+)
> > > >  create mode 100644 libavcodec/jpeg2000_parser.c
> > >
> > > The code seems to work fine, is there a reason why it has a "RFC" in the
> > > subject. That is, should this be reviewed & applied or not yet ?
> > I wanted to get the fate test also reviewed. If this looks fine to
> > everyone, this can
> > be applied and the FATE test can be reviewed separately.
> > >
> > > thx
> > >
> > > [...]
> > > --
> > > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> > >
> > > Good people do not need laws to tell them to act responsibly, while bad
> > > people will find a way around the laws. -- Plato
> > > _______________________________________________
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel at ffmpeg.org
> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >
> > > To unsubscribe, visit link above, or email
> > > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> >
> >
> >
> > --
> > -------------
> > Gautam |
> 
> 
> Should I resubmit this patch, or can it be accepted from here?

probably it can be, but if you resubmit then please check the
formating, there are some inconsitancies like ) { vs ){

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200605/8e0b2392/attachment.sig>