[FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

[Gautam Ramakrishnan]

On Wed, Jun 3, 2020 at 3:27 AM Michael Niedermayer
<michael at niedermayer.cc> wrote:
>
> On Wed, Jun 03, 2020 at 12:49:10AM +0530, Gautam Ramakrishnan wrote:
> > On Tue, Jun 2, 2020 at 1:55 AM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > >
> > > Am Mo., 1. Juni 2020 um 21:26 Uhr schrieb Gautam Ramakrishnan
> > > <gautamramk at gmail.com>:
> > >
> > > > > > > can you add some test to fate for this ?
> > > > > > > (doesnt need to be related to the tests you did, but can of course)
> > > > > > > such a test would also make it easy for others to test the code on
> > > > > > > less common hardware like big endian ...
> > > > > > > This can also be very simple test if its not easy
> > > > > > Small doubt, so the jpeg2000 stream to be parsed goes in the
> > > > > > test-suite directory and the corresponding framecrc goes into the
> > > > > > test/ref directory? Is my understanding right?
> > > > >
> > > > > ideally the teststream is generated by our muxers / encoders, that way
> > > > > it doesnt need to be added to the fate suite
> > > > > and it also teste more code as a side effect
> > > > I did not understand this clearly. Do you mean the test should take some
> > > > images already there in the test-suite, create a teststream, and run the test
> > > > on that teststream?
> > >
> > > This is possible but using -f lavfi -i testsr2 as input may be simpler.
> > I assume, this is the right link to refer to create the test
> > https://trac.ffmpeg.org/wiki/FATE/AddingATest
>
> > I could run the enc_dec_pcm, where I encode the
> > lavfi generated stream and decode it using jpeg2000 codec?
>
> enc_dec_pcm is for audio, but maybe i misunderstand your suggestion
>
So my plan for the test was, to create a rawvideo consisting of JPEG2000 frames.
These frames would be generated using lavfi.
An example command would be:
ffmpeg  -f lavfi -i "testsrc2=s=640x480" -t 1 -c:v jpeg2000 -f
rawvideo parser_trial.rawvideo
The parser could be tested by trying to decode parser_trial.rawvideo
to framecrc.

To translate this into a test, I thought of using the enc_dec command.
However, I am unable
to pass lavfi stream as an input as it assumes that a filename is being passed.
What is a possible solution for this? Can I fix fate-run.sh so that if
the source format is lavfi
do not convert the parameter to a path?
The documentation for adding a test was slightly underwritten, so I
have inferred whatever I can
by reading the code.
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Concerning the gods, I have no means of knowing whether they exist or not
> or of what sort they may be, because of the obscurity of the subject, and
> the brevity of human life -- Protagoras
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



-- 
-------------
Gautam |