[FFmpeg-devel] [PATCH] avformat/dashenc: use AVCodecContext timebase when computing missing bitrate

Jeyapal, Karthick kjeyapal at akamai.com
Mon Jun 1 16:30:18 EEST 2020


On 6/1/20 5:24 PM, Przemysław Sobala wrote:
> On Mon, Jun 1, 2020 at 10:06 AM Anton Khirnov <anton at khirnov.net> wrote:
>
>> Quoting Przemysław Sobala (2020-05-27 17:07:22)
>>> ---
>>>  libavformat/dashenc.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
>>> index 0cf0df50ef..00a37b175d 100644
>>> --- a/libavformat/dashenc.c
>>> +++ b/libavformat/dashenc.c
>>> @@ -1959,7 +1959,7 @@ static int dash_flush(AVFormatContext *s, int
>> final, int stream)
>>>
>>>          if (!os->bit_rate) {
>>>              // calculate average bitrate of first segment
>>> -            int64_t bitrate = (int64_t) range_length * 8 * AV_TIME_BASE
>> / duration;
>>> +            int64_t bitrate = (int64_t) range_length * 8 *
>> (c->use_timeline ? os->ctx->streams[0]->time_base.den : AV_TIME_BASE) /
>> duration;
>>
>> That does not look like an AVCodecContext
>>
>
> Of course not. time_base is AVStream's field. I don't know why I wrote
> AVCodecContext... Please amend that commit message if possible.
Amended and Pushed!

Thanks,
Karthick
>
> --
> Przemysław Sobala
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://urldefense.proofpoint.com/v2/url?u=https-3A__ffmpeg.org_mailman_listinfo_ffmpeg-2Ddevel&d=DwIGaQ&c=96ZbZZcaMF4w0F4jpN6LZg&r=xOoesbz-6ff1GPXp5Lg4jf1ZG99yp4a1qhxVn_YOwRU&m=d5_uQoLoKY0i_-ZFJQGxnQcD0feA0He0ST4ojg4---4&s=dstVnsDMFsrakFvnEaO5zT4dmLntnO4RBfr7YTHwI_4&e= 
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



More information about the ffmpeg-devel mailing list