[FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

[mypopy at gmail.com]

On Thu, Jul 30, 2020 at 5:15 PM mypopy at gmail.com <mypopy at gmail.com> wrote:
>
> On Thu, Jul 30, 2020 at 5:12 PM Nicolas George <george at nsup.org> wrote:
> >
> > zongwave (12020-07-31):
> > > From: Yinhang Liu <yinhangx.liu at intel.com>
> > >
> > > xcam filter is a wrapper of libxcam project which supports 360 video stitching,
> > > automotive surround view stitching, digital video stabilization (DVS),
> > > Wide dynamic range (WDR), wavelet noise reduction, 3D noise reduction, etc.
> >
> > Hi. Thanks for the patch. But it seems to have been generated in a
> > strange way, with double insertion marks. Did you commit your changes
> > and then use git format-patch or git send-email?
> >
> > Regards,
> >
> > --
> >   Nicolas George
>
> The other thing is, I found libxcam (https://github.com/intel/libxcam)
> depend on a lot of 3rd libs
> "
> If --enable-gst, need install libgstreamer1.0-dev,
> libgstreamer-plugins-base1.0-dev
> If --enable-aiq, need get ia_imaging lib which we don't support
> If --enable-libcl, need compile or install OpenCL driver
> If --enable-opencv, suggest OpenCV versions [3.0.0 - 4.0.0) (or: OpenCV Wiki)
> If --enable-render, need compile OpenSceneGraph library with configure
> option "-DOSG_WINDOWING_SYSTEM=X11"
> If --enable-gles, need to install Mesa3D library
> If --enable-vulkan, need to install Mesa3D library
> If --enable-avx512, need to install GCC version > 4.9 ( CPUs With
> AVX-512 required)
> If --enable-dnn, need to compile OpenVino inference-engine
> If --enable-json, need to install json.hpp
> "
> Is it a good idea to wrap a lib like this in AVFilter?

My confusion is, where is the boundary of FFmpeg？
in my personal opinion, libxcam is not a self-contained library.