[FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

[James Almer]

On 7/29/2020 7:50 PM, Mark Thompson wrote:
> Matching libaom-av1.
> ---
>  libavcodec/libsvt_av1.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/libavcodec/libsvt_av1.c b/libavcodec/libsvt_av1.c
> index c7ae5f9691..3229551d2b 100644
> --- a/libavcodec/libsvt_av1.c
> +++ b/libavcodec/libsvt_av1.c
> @@ -483,7 +483,7 @@ static const AVOption options[] = {
>          { "3level", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 3 },  INT_MIN, INT_MAX, VE, "hielevel" },
>          { "4level", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 4 },  INT_MIN, INT_MAX, VE, "hielevel" },
>  
> -    { "la_depth", "Look ahead distance [0, 120]", OFFSET(la_depth),
> +    { "la-depth", "Look ahead distance [0, 120]", OFFSET(la_depth),
>        AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 120, VE },
>  
>      { "preset", "Encoding preset [0, 8]",
> @@ -533,7 +533,7 @@ static const AVOption options[] = {
>      { "qp", "QP value for intra frames", OFFSET(qp),
>        AV_OPT_TYPE_INT, { .i64 = 50 }, 0, 63, VE },
>  
> -    { "sc_detection", "Scene change detection", OFFSET(scd),
> +    { "sc-detection", "Scene change detection", OFFSET(scd),
>        AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE },
>  
>      { "tile-columns", "Log2 of number of tile columns to use", OFFSET(tile_columns), AV_OPT_TYPE_INT, {.i64 = 0}, 0, 4, VE},
> @@ -543,7 +543,7 @@ static const AVOption options[] = {
>  };
>  
>  static const AVClass class = {
> -    .class_name = "libsvt_av1",
> +    .class_name = "libsvt-av1",
>      .item_name  = av_default_item_name,
>      .option     = options,
>      .version    = LIBAVUTIL_VERSION_INT,
> @@ -558,7 +558,7 @@ static const AVCodecDefault eb_enc_defaults[] = {
>  };
>  
>  AVCodec ff_libsvt_av1_encoder = {
> -    .name           = "libsvt_av1",
> +    .name           = "libsvt-av1",
>      .long_name      = NULL_IF_CONFIG_SMALL("SVT-AV1(Scalable Video Technology for AV1) encoder"),
>      .priv_data_size = sizeof(SvtContext),
>      .type           = AVMEDIA_TYPE_VIDEO,
> @@ -573,5 +573,5 @@ AVCodec ff_libsvt_av1_encoder = {
>      .priv_class     = &class,
>      .defaults       = eb_enc_defaults,
>      .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP,
> -    .wrapper_name   = "libsvt_av1",
> +    .wrapper_name   = "libsvtav1",
>  };

The name could also be simply libsvtav1, same as the library (and the
configure option), since unlike libvpx and (in theory) libaom, no other
codec will be supported by it. HEVC is in a different library.

LGTM either way.