[FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

Zlomek, Josef josef at pex.com
Wed Jul 29 13:54:47 EEST 2020


On Wed, Jul 29, 2020 at 12:01 PM Nicolas George <george at nsup.org> wrote:

> I am afraid ff_make_absolute_url() as it is is broken beyond repair. For
> example:
>
> http://server/menu redirect?url=http://otherserver/target =>
>   redirect?url=http://otherserver/target
>
> while the result should have been
>
> http://server/redirect?url=http://otherserver/target
>
> I will have a shot at rewriting it cleanly, with proper parsing of URL
> components.
>

I also noticed that there are many more bugs in ff_make_absolute_url()
I just fixed one of them.
I am looking forward for your complete fix.

Best regards,
Josef


More information about the ffmpeg-devel mailing list