[FFmpeg-devel] [PATCH 1/6] vaapi_encode_h265: Remove confusing and redundant tile options

Fu, Linjie linjie.fu at intel.com
Wed Jul 29 09:08:40 EEST 2020


> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Mark Thompson
> Sent: Wednesday, July 29, 2020 06:50
> To: ffmpeg-devel at ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 1/6] vaapi_encode_h265: Remove
> confusing and redundant tile options
> 
> The tile_rows/cols options currently do a confusingly different thing to
> the options of the same name on other encoders like libvpx and libaom.
> There is no backward-compatibility reason to implement the log2 behaviour
> as there was for libaom, so just get rid of them entirely.

Ok, previously I'm following the implementation in librav1e [1] which uses a non-log2
value as the input of "tile-rows" and "tile-columns".
(Do we need to make it consistent as well?)

[1] https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/librav1e.c#L567

- Linjie


More information about the ffmpeg-devel mailing list