[FFmpeg-devel] [PATCH 7/7] avfilter: add afwtdn filter

Valentin Schweitzer valentin.schweitzer98 at gmail.com
Thu Jul 23 15:43:35 EEST 2020


On 12/06/2020 00:58, Nicolas George wrote:
> Paul B Mahol (12020-06-12):
>> FFmpeg is not math encyclopedia.
> You did not type these numbers, you took them from somewhere. Include it
> in the source code, where it belongs.

I am not familiar with the entirety of this commit, but this
seems to concern wavelet coefficients. I think linking a source
for these coefficients that leads to further documentation instead
of including this in the source code is a good idea.

For anyone looking for such a source, http://wavelets.pybytes.com/wavelet/sym2/
offers a list of (rounded) coefficients (the specific link is for Symlets 2).
Paul seems to have a source for either a more accurate list or the formulas to
calculate these values. Linking this in the source might be really helpful for
quick debugging or adapting the code later.

I hope this comment was helpful in any way,

-Valentin



More information about the ffmpeg-devel mailing list