[FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

[Paul B Mahol]

On 7/20/20, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Thu, Jun 11, 2020 at 08:31:57PM +0200, Nicolas George wrote:
>> Paul B Mahol (12020-06-11):
>> > Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> > ---
>> >  libavfilter/avfilter.c | 61 +++++++++++++++++++++++++++++++++++++-----
>> >  libavfilter/filters.h  | 17 ++++++++++++
>> >  2 files changed, 72 insertions(+), 6 deletions(-)
>>
>> Still no. It makes a very important function much more complex, it would
>> be simpler implemented in the filters directly since they are not using
>> the full features of the queue.
>
> shouldnt code which is used by multiple filters be shared and available
> to all filters ?
> but maybe iam missing something
>
> And it would be nice if you and paul could come up with some solution
> which you both are happy with
> because i dont think arbitration by someone is going to make both of
> you happy. No matter what the result, likely one at least would be unhappy

Preferring status quo make Nicolas happy.

>
> Thanks
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Dictatorship naturally arises out of democracy, and the most aggravated
> form of tyranny and slavery out of the most extreme liberty. -- Plato
>