[FFmpeg-devel] [PATCH 9/9] avformat/concatdec: Simplify cleanup after read_header failure

Nicolas George george at nsup.org
Tue Jul 21 18:24:59 EEST 2020


Andreas Rheinhardt (12020-07-21):
> by setting the AVFMT_HEADER_CLEANUP flag.
> 
> (Btw: concat_read_close() is not idempotent (it frees cat->files, but
> doesn't reset cat->nb_files), so this demuxer was incompatible with
> simply calling read_close generically upon read_header failure.)

If you think it would useful or more elegant to reset nb_files when
freeing files, then by all means go ahead. I agree on the elegance part
at least, but I do not have the time right now.

The patch looks ok anyway, thanks.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200721/5c57d995/attachment.sig>


More information about the ffmpeg-devel mailing list