[FFmpeg-devel] [PATCH] avfilter: add radial and circular blur video filter

Steinar H. Gunderson steinar+ffmpeg at gunderson.no
Sat Jul 18 13:58:18 EEST 2020


On Sat, Jul 18, 2020 at 12:53:18PM +0200, Paul B Mahol wrote:
> Nope, algorithm is just fine. You are interpreting results wrongly.

If you are not willing to tell me what is wrong with my interpretation
(outside “you are using the wrong parameters, and I won't tell you what the
right parameters are”), this is a hard claim to make.

In short, this patch has:

 - An unusually slow algorithm (sin, cos, atan, division; all per-pixel).
 - Poor output quality (strong aliasing, no subpixel precision).
 - No comments, hardly any commit message.

Thus, I believe it should not be merged.

/* Steinar */
-- 
Homepage: https://www.sesse.net/


More information about the ffmpeg-devel mailing list