[FFmpeg-devel] [PATCH 2/2] swscale/tests/swscale: use codes < 128 for indicating erros

[Michael Niedermayer]

On Thu, Jul 16, 2020 at 10:57:27AM +0300, Martin Storsjö wrote:
> On Thu, 16 Jul 2020, Michael Niedermayer wrote:
> 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> > libswscale/tests/swscale.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.c
> > index 845ced61bb..9c0b5a4b11 100644
> > --- a/libswscale/tests/swscale.c
> > +++ b/libswscale/tests/swscale.c
> > @@ -248,7 +248,7 @@ end:
> >         if (dstStride[i])
> >             av_free(dst[i]);
> > 
> > -    return res;
> > +    return res & 127;
> > }
> 
> Is there a valuable distinction between the different return values in this
> test tool so far? Because this code will e.g. fail to return a proper error
> return code if res happens to be -128.

currently no difference


> 
> Otherwise this could be made into e.g. "return !!res;" or something like
> that.

ok will push with that

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200716/10f26502/attachment.sig>