[FFmpeg-devel] [PATCH 3/6] avcodec/h264_slice: export S12M timecode side data

[lance.lmwang at gmail.com]

On Wed, Jul 15, 2020 at 06:02:43PM +0100, Kieran Kunhya wrote:
> On Wed, 15 Jul 2020 at 16:52, <lance.lmwang at gmail.com> wrote:
> 
> > On Wed, Jul 15, 2020 at 04:16:38PM +0100, Kieran Kunhya wrote:
> > > If you look a few lines above, we already set the timecode side data.
> > >
> >
> > are you saying av_frame_new_side_data() above?  that's total different, in
> > fact,
> > I'm try to use the same way with ff_add_cpb_side_data(), it'll put TC in
> > the codec
> > level: avctx->nb_coded_side_data instead of frame level. By this way, I
> > can export
> > the correct TC in the following patch for movenc, dv file format. Please
> > refer to:
> > libavformat/utils.c line 4154 add_coded_side_data() is used to copy all
> > AVPacketSideData
> > side data to st level. If someone have better way to reuse the frame side
> > data, please give your advice.
> >
> 
> Sorry this makes no sense at all.
> What has decoding got to do with muxing?

No, it's used for copy the TC if you want to copy a video with frame-level TC to 
a stream level file. It looks duplicated for I haven't figured out where is
proper place to copy the frame-level side data to packet-level side data or global
level, if no good place, I'll do the copy in the encode_frame() like v210enc.

> 
> Kieran
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang