[FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

[mypopy at gmail.com]

On Sun, Jul 12, 2020 at 8:39 PM Moritz Barsnick <barsnick at gmx.net> wrote:
>
> On Sun, Jul 12, 2020 at 14:03:03 +0800, Jun Zhao wrote:
> > From: Jun Zhao <barryjzhao at tencent.com>
>
> (Which thread are you replying to?)
>
> > libsrt 1.4.1 changed the:
> > SRTO_SMOOTHER   -> SRTO_CONGESTION
>
> AFAICT, this was changed in 1.3.3 (even though the commit doesn't
> change the doc/API.md where it states 1.3.0):
> https://github.com/Haivision/srt/commit/6f6b76b381ba8854fcd699908f74fae4cfce6783
>
> > SRTO_STRICTENC  -> SRTO_ENFORCEDENCRYPTION
>
> This was changed in 1.4.0. Does this codec compile with 1.4.0 after your
> fix? Did it ever?
> https://github.com/Haivision/srt/commit/a82e0c34b0aadcb309d9e2f322b26f8f59bf827a
>
> > SRTO_TSBPDDELAY -> SRTO_LATENCY
>
> You didn't change any code regarding these two, and anyway,
> SRTO_LATENCY has existed as an alias since 1.2.0:
> https://github.com/Haivision/srt/commit/508eeeb8dec6bcee123fa0d1d7f7fe3b0060eb77
>
> Considering that 1.4.0 was released 10 months ago, I wonder whether
> anyone compiled against a recent libsrt since then?
>
> Cheers,
> Moritz
Maybe I give an inaccurate description in the commit message, in fact,
libsrt 1.4.1 remove the SRTO_STRICTENC/SRTO_SMOOTHER option, it's will
lead to FFmpeg build fail when using libsrt  version >= 1.4.1