[FFmpeg-devel] [PATCH v2 1/3] libavutil/imgutils: add utility to get plane sizes

Nicolas George george at nsup.org
Fri Jul 10 15:03:19 EEST 2020


James Almer (12020-07-09):
> int av_image_fill_plane_sizes(size_t *size, size_t planesizes[4], enum
> AVPixelFormat pix_fmt, int height, const ptrdiff_t linesizes[4])
> 
> But it's also somewhat ugly and inconsistent with other functions in
> this module.

I find this is by far the best solution. Even more so since the total
size is not the main output of the function as specified by its name. It
is also more future-proof, and allows potential consistency for cases
that return a pointer.

I would be curious to know what you find ugly with this; I am frequently
baffled by similar judgements of yours. Would you try to analyze it?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200710/f54cd607/attachment.sig>


More information about the ffmpeg-devel mailing list