[FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

[Carl Eugen Hoyos]

Am Mi., 8. Juli 2020 um 07:28 Uhr schrieb Josef Zlomek <josef at pex.com>:
>
> Fixes: 4907

It seems surprising that two commits should fix a ticket.

> Adds support for demuxing of animated WebP.

Does this demuxer also support single frame files?
What about concatenated webps?

[...]

> +static int webp_probe(const AVProbeData *p)
> +{
> +    const uint8_t *b = p->buf;
> +
> +    if (p->filename && ff_guess_image2_codec(p->filename)) {

Why is this useful?

> +        if (AV_RB32(b)     == MKBETAG('R', 'I', 'F', 'F') &&
> +            AV_RB32(b + 8) == MKBETAG('W', 'E', 'B', 'P'))
> +            return AVPROBE_SCORE_MAX;
> +    }

[...]


> +    frame_end = avio_tell(pb);
> +
> +    if (avio_seek(pb, frame_start, SEEK_SET) != frame_start)
> +        return AVERROR(EIO);

Instead I believe you should use ffio_ensure_seekback() or do
I miss something?
Same above.

Carl Eugen