[FFmpeg-devel] [PATCH] [GSoC 1/6] avformat/abr: Adaptive Bitrate support

[Martin Storsjö]

On Sun, 5 Jul 2020, Hongcheng Zhong wrote:

> From: spartazhc <spartazhc at gmail.com>
>
> Add abr module for hls/dash.
>
> Signed-off-by: spartazhc <spartazhc at gmail.com>
> ---
> doc/protocols.texi      |   7 +
> libavformat/Makefile    |   1 +
> libavformat/abr.c       | 282 ++++++++++++++++++++++++++++++++++++++++
> libavformat/protocols.c |   1 +
> 4 files changed, 291 insertions(+)
> create mode 100644 libavformat/abr.c


> +const URLProtocol ff_abr_protocol = {
> +    .name                = "abr",

If this protocol isn't a protocol that an end user would invoke (it isn't 
- there's no standard abr:// protocol), it would be good to more clearly 
mark it as an internal implementation detail instead of an end user facing 
protocol, e.g. by adding an "ff" prefix to the protocol name, like the 
existing ffrtmpcrypt protocol.

That said I haven't reviewed the concept itself though.

// Martin