[FFmpeg-devel] patch submission questions

Manolis Stamatogiannakis mstamat at gmail.com
Mon Jul 6 00:51:14 EEST 2020


Thanks for the tips Andriy.

To make it easier for future new contributors I took the time to update
developers.texi with the information I got from this thread, and revamp the
chapter about submitting patches.

Feedback is most welcome.

Best regards,
Manolis



On Sun, 5 Jul 2020 at 20:56, Andriy Gelman <andriy.gelman at gmail.com> wrote:

> On Sun, 05. Jul 20:34, Manolis Stamatogiannakis wrote:
> > On Sun, 5 Jul 2020 at 15:48, Hongcheng Zhong <sj.hc_Zhong at sjtu.edu.cn>
> > wrote:
> >
> > >
> > > You can use `git format-patch -v<n> -n<n>` to get patches like [PATCH
> > > v2 1/20]. See git-format-patch documentation for more details.
> > >
> > >
> > That didn't quite work.
> >
> > I used "git format-patch -s -n -v3 --to ffmpeg-devel at ffmpeg.org
> > HEAD~2..HEAD" and "git send-email -2".
> >
> > But the -v argument was dropped and the end results on patchwork were
> again:
> > [FFmpeg-devel,2/2] avfilter/vf_subtitles: Added shift option for
> > subtitles/ass filters.
> > [FFmpeg-devel,1/2] avfilter/vf_subtitles: Reorganized subtitles filter
> > options.
> >
>
> git send-email -v2 HEAD~ # works for me
>
> git shows are draft of the email before sending. Check that the subject
> line
> contains the version number (or you can send the patch to yourself)
>
> For patchwork, you can create an account and set your old patches as
> 'Superseded'.
> I also periodically run a script that sets Superseded and Accepted labels.
>
> --
> Andriy
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list