[FFmpeg-devel] patch submission questions

Manolis Stamatogiannakis mstamat at gmail.com
Sun Jul 5 18:59:54 EEST 2020


Thanks for the responses Hongcheng and Steinar!

I'll use '-n' with git format-patch if I need to resubmit. Patches already
work as Steinar describes.

In the meantime patch 2/3 found its way to patchwork. The delay was
probably due to some email processing hiccup.

So all is good!

Cheers,
Manolis


On Sun, 5 Jul 2020 at 16:06, Steinar H. Gunderson <
steinar+ffmpeg at gunderson.no> wrote:

> On Sun, Jul 05, 2020 at 03:42:34PM +0200, Manolis Stamatogiannakis wrote:
> > Q2: In a patchset consisting of several commits, is each commit expected
> to
> > be "standalone"? I.e. does it have to apply cleanly without depending on
> > the previous commits in the patchset?
>
> No, but it has to compile and work even if not applying any of the latter
> patches.
> (This increases reviewability and bisectability.) AFAIK Patchwork doesn't
> enforce this, though.
>
> /* Steinar */
> --
> Homepage: https://www.sesse.net/
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list