[FFmpeg-devel] [PATCH v7 1/2] libavcodec/pgxdec: Add PGX decoder

Michael Niedermayer michael at niedermayer.cc
Sat Jul 4 19:38:10 EEST 2020


On Sat, Jul 04, 2020 at 03:32:31PM +0200, Nicolas George wrote:
> Gautam Ramakrishnan (12020-07-04):
> > > Minor: we could have FFBETWEEN() for that.
> > I shall use this.
> 
> You would need to add it first, which is ok by me.
> 
> Note that (x >= a) && (x < b) can be written in a more efficient way:
> 
> 	(unsigned)x - a < (unsigned)b - a

I dont think this FFBETWEEN macro is a great idea
if someone used it with int64_t or with a float this would all not work
and its easy to do that the name FFBETWEEN doesnt suggest that its int
specific

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200704/527c1ef3/attachment.sig>


More information about the ffmpeg-devel mailing list