[FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand index

Guo, Yejun yejun.guo at intel.com
Thu Jul 2 04:30:34 EEST 2020



> -----Original Message-----
> From: Michael Niedermayer <michael at niedermayer.cc>
> Sent: 2020年7月2日 7:45
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>;
> Guo, Yejun <yejun.guo at intel.com>
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand
> index
> 
> On Wed, Jun 17, 2020 at 03:23:34AM +0000, Guo, Yejun wrote:
> >
> >
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > > Carl Eugen Hoyos
> > > Sent: 2020年6月16日 18:57
> > > To: FFmpeg development discussions and patches
> > > <ffmpeg-devel at ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check
> > > operand index
> > >
> > >
> > >
> > > > Am 16.06.2020 um 10:18 schrieb Guo, Yejun <yejun.guo at intel.com>:
> > > >
> > > > I personally like to always add '{}' to avoid possible mistakes
> > > > when we change
> > > code in the future. Some coding styles also recommend this method.
> > > >
> > > > I checked at http://ffmpeg.org/developer.html#Coding-Rules and do
> > > > not find
> > > an explicit description. But I just remembered that someone also
> > > mentioned this some time ago. I'll change to this style in v2 if no
> > > support from others for my style.
> > >
> > > I support your style but it is only the file maintainer‘s decision.
> >
> > thanks, I'll keep the V1 patch and push soon.
> 
> please also apply this to affected release branches

done, pushed to branch 4.3 with dd273d359e45ab69398ac0dc41206d5f1a9371bf and 5530748bfdf1a4d41d4c92e59f662c94e38a5f94,
no need to apply 4.2 and older.


More information about the ffmpeg-devel mailing list