[FFmpeg-devel] [PATCH] avdevice/pulse_audio_dec: identify channel layout

[Federico Simoncelli]

On Sun, Jan 26, 2020 at 6:18 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
> > Am 26.01.2020 um 17:42 schrieb Federico Simoncelli <federico.simoncelli at gmail.com>:
> >
> > On Sun, Jan 26, 2020 at 4:33 PM Carl Eugen Hoyos <ceffmpeg at gmail.com>
> > wrote:
> >> Can you confirm that with the existing code, user could set the
> >> channel_layout
> >> for everything >= 3 channels? Does this still work after your patch?
> >
> > Hi Carl, thanks for asking, actually I caught a segfault with >= 3
> > channels.
>
> Please elaborate.

The issue is fixed in the patch announced by this message and the
change introduced is the check for map_name == NULL.

That ensures that when we specify or force a particular number of
channels (e.g. -ac 3 or -channels 3, or higher) or whenever pulse
cannot provide a channel map (NULL) then we fallback to the regular
channel guessing in place before (channel_layout = 0).

-- 
Federico