[FFmpeg-devel] [PATCH] lavc/dvdsubenc: accept palette from options

[Andreas Rheinhardt]

On Fri, Jan 24, 2020 at 7:26 PM Michael Kuron <michael.kuron at gmail.com>
wrote:

> Previously, the default palette would always be used.
> Now, we can accept a custom palette, just like dvdsubdec does.
>
> Signed-off-by: Michael Kuron <michael.kuron at gmail.com>
> ---
>  doc/encoders.texi      |  9 +++++++++
>  libavcodec/dvdsubenc.c | 19 ++++++++++++++++++-
>  2 files changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/doc/encoders.texi b/doc/encoders.texi
> index eefd124751..f8d5ecb5f9 100644
> --- a/doc/encoders.texi
> +++ b/doc/encoders.texi
> @@ -3115,6 +3115,15 @@ and they can also be used in Matroska files.
>
>  @subsection Options
>
> + at table @option
> + at item palette
> +Specify the global palette used by the bitmaps.
> +
> +The format for this option is a string containing 16 24-bits hexadecimal
> +numbers (without 0x prefix) separated by comas, for example @code{0d00ee,
> +ee450d, 101010, eaeaea, 0ce60b, ec14ed, ebff0b, 0d617a, 7b7b7b, d1d1d1,
> +7b2a0e, 0d950c, 0f007b, cf0dec, cfa80c, 7c127b}.
> +
>

You are adding another table (that you don't close), whereas you should
only add an item to the already existing table. As a consequence, building
fails when one also builds the documentation
<https://patchwork.ffmpeg.org/check/1954/>.

- Andreas