[FFmpeg-devel] [PATCH 2/2] avcodec/dnxhdenc: properly store colorspace info

Carl Eugen Hoyos ceffmpeg at gmail.com
Fri Jan 24 18:09:58 EET 2020


Am Fr., 24. Jan. 2020 um 17:05 Uhr schrieb James Almer <jamrial at gmail.com>:
>
> On 1/24/2020 12:59 PM, Paul B Mahol wrote:
> > On 1/24/20, James Almer <jamrial at gmail.com> wrote:
> >> On 1/24/2020 11:14 AM, Paul B Mahol wrote:
> >>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >>> ---
> >>>  libavcodec/dnxhdenc.c | 11 ++++++++++-
> >>>  libavcodec/dnxhdenc.h |  1 +
> >>>  2 files changed, 11 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
> >>> index 2feb8baf21..03835fa794 100644
> >>> --- a/libavcodec/dnxhdenc.c
> >>> +++ b/libavcodec/dnxhdenc.c
> >>> @@ -406,6 +406,15 @@ static av_cold int dnxhd_encode_init(AVCodecContext
> >>> *avctx)
> >>>      }
> >>>
> >>>      ctx->is_444 = ctx->profile == FF_PROFILE_DNXHR_444;
> >>> +
> >>> +    switch (avctx->colorspace) {
> >>> +    case AVCOL_SPC_UNSPECIFIED:
> >>
> >> Isn't 3 meant to be unspecified? If not, what is it for?
> >
> > This is to keep old behavior same. Where encoder would store
> > unspecified as bt709.
> > Mainly to not need to modify fate tests.
>
> The proper thing to do is adapt the tests to the new correct behavior,
> not keeping an encoder doing things technically wrong just to not update
> the tests.

But this could be an independent patch which would be better.

Carl Eugen


More information about the ffmpeg-devel mailing list