[FFmpeg-devel] [PATCH 3/4] avfilter/asrc_sine: Fix invalid left shift of negative number

Nicolas George george at nsup.org
Wed Jan 22 19:50:05 EET 2020


Andreas Rheinhardt (12020-01-22):
> by using a multiplication instead. The multiplication can never overflow
> an int because the sin-factor is only an int16_t.

No objection.

> Affected the FATE-tests filter-concat and filter-concat-vfr.

I find that suspect, the change is only theoretical. What architecture
are giving this?

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200122/db8a7737/attachment.sig>


More information about the ffmpeg-devel mailing list