[FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for argonaut games' ASF format

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Jan 22 02:42:41 EET 2020


Am Mi., 22. Jan. 2020 um 01:41 Uhr schrieb Zane van Iperen
<zane at zanevaniperen.com>:
>
> 22/1/20 10:30 am, Carl Eugen Hoyos пишет:
> >
> > Am Mi., 22. Jan. 2020 um 01:13 Uhr schrieb Zane van Iperen
> > <zane at zanevaniperen.com>:
> >
> >> Ah, sorry I misunderstood. How's this?
> >>
> >>   >    if (hdr.magic != ASF_TAG)
> >>   >        return 0;
> >>   >
> >>   >    if (!argo_asf_is_known_version(&hdr))
> >>   >        return 25;
> >>   >
> >>   >    return (AVPROBE_SCORE_MAX / 2) + 1;
> >
> > I like this much better, use AVPROBE_SCORE_EXTENSION / 2 and
> > AVPROBE_SCORE_EXTENSION + 1 as it's done in other places.
> >
>
> Done. Is it worth sending a v4 for such a small change, or should
> I just send an additional patch?

Do not send patches to change patches that are not committed yet.

Carl Eugen


More information about the ffmpeg-devel mailing list