[FFmpeg-devel] [PATCH] avformat/hlsenc: compiler warning fix

[Carl Eugen Hoyos]

Am Mo., 20. Jan. 2020 um 13:18 Uhr schrieb Bodecs Bela <bodecsb at vivanet.hu>:
>
>
> 2020.01.20. 13:07 keltezéssel, Carl Eugen Hoyos írta:
> > Am Mo., 20. Jan. 2020 um 09:41 Uhr schrieb Bodecs Bela <bodecsb at vivanet.hu>:
> >>
> >> 2020.01.20. 8:46 keltezéssel, Andreas Rheinhardt írta:
> >>> On Mon, Jan 20, 2020 at 8:35 AM Bodecs Bela <bodecsb at vivanet.hu> wrote:
> >>>
> >>>> Dear All,
> >>>>
> >>>> This patch corrects compiler warning about returning possibly uninitialized
> >>>> variable in hls_write_header function.
> >>>>
> >>>> Which compiler warns about this?
> >> libavformat/hlsenc.c: In function ‘hls_write_header’:
> >> libavformat/hlsenc.c:2174: warning: ‘ret’ may be used uninitialized in
> >> this function
> > Looks like a false positive, does not warn with newer compilers.
>
> yes and no.
>
> no, because if hls->nb_varstreams == 0, then for loop body never
> executes and so ret does not get any value.
>
> yes, because there is no chance for hls->nb_varstreams to be zero.
>
> so, I think setting ret to 0 at its declaration does not do any problem
> and logically right.

No, update your compiler instead.

Carl Eugen