[FFmpeg-devel] [PATCH v2 1/2] avcodec: add decoder for argonaut games' adpcm codec

[Zane van Iperen]

20/1/20 7:24 am, Tomas Härdin пишет:
> 
> sön 2020-01-19 klockan 08:33 +0000 skrev Zane van Iperen:
>> Adds support for the ADPCM variant used by some Argonaut Games'
>> games,
>> such as 'Croc! Legend of the Gobbos', and 'Croc 2'.
>>
>> Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
>> ---
>>   Changelog               |   2 +-
>>   doc/general.texi        |   1 +
>>   libavcodec/Makefile     |   1 +
>>   libavcodec/adpcm_argo.c | 264
>> ++++++++++++++++++++++++++++++++++++++++
>>   libavcodec/allcodecs.c  |   1 +
>>   libavcodec/avcodec.h    |   1 +
>>   libavcodec/codec_desc.c |   7 ++
>>   libavcodec/version.h    |   2 +-
>>   8 files changed, 277 insertions(+), 2 deletions(-)
>>   create mode 100644 libavcodec/adpcm_argo.c
>>
> 
> Is there any reason why this can't share code with the other ADPCM
> decoders?
> 
> /Tomas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> 

Technically it could, but other than some very minor boilerplate code,
there doesn't seem to be much overlap. Also, adpcm.c is rather big at nearly 2000 lines,
so I'd rather not add it. Personally, I'd prefer to keep it separate.

It seems neater.

Zane