[FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for argonaut games' ASF format

[Zane van Iperen]

On 20/1/20 2:34 am, Moritz Barsnick wrote:
> 
> Just one more:
> 
> On Sun, Jan 19, 2020 at 08:33:45 +0000, Zane van Iperen wrote:
> 
>> +    if (av_match_ext(p->filename, "asf"))
>> +        score += AVPROBE_SCORE_EXTENSION;
> 
> Just a remark: The asf demuxer (for Microsoft's "Advanced System
> Format") also considers ".asf" as a valid extension. I don't know
> whether this clashes in any way though. You'd probably need to throw
> both types of "ASF" files at these probes.
> 
> Cheers,
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> 

They might have the same extension, but that's where the similarities
end. I just had a look at the Microsoft ASF spec and they start with a
GUID, so a "proper" ASF will hit the `hdr.magic != ASF_TAG` check.

The probing code in asfdec_f.c seems to confirm this as well.


Zane