[FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for argonaut games' ASF format

[Andreas Rheinhardt]

Zane van Iperen:
> 19/1/20 2:18 pm, Andreas Rheinhardt пишет:
>>
>> On Sun, Jan 19, 2020 at 4:12 AM Zane van Iperen <zane at zanevaniperen.com>
>> wrote:
>>
>>> Adds support for the custom ASF container used by some Argonaut Games'
>>> games, such as 'Croc! Legend of the Gobbos', and 'Croc 2'.
>>>
>>> Can also handle the sample files in:
>>> https://samples.ffmpeg.org/game-formats/brender/part2.zip
>>>
>>> Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
...
>>> +    score = 0;
>>> +    if (av_match_ext(p->filename, "asf"))
>>> +        score += AVPROBE_SCORE_EXTENSION;
>>> +
>>> +    hdr = *(ArgoASFFileHeader*)p->buf;
>>> +    argo_asf_fix_header_endianness(&hdr);
>>> +
>>>
>>
>> You are modifying the probe buffer. I don't think you are supposed to do
>> that (although the AVProbeData,buf is not a pointer to const uint8_t).
>> Instead read what you need with AV_RL from the buffer.
>>
> hdr is a stack variable. I'm simply assigning it from the buffer, so nothing's being changed.
> It's a moot point anyway, since I've changed it to use AV_RL.
> 
True. I only saw the cast and not the * before it.

...
> 
> 
> Do I need to submit only the revised commit or do I resend the entire series as a "v2"?
> 
> Also, should I include any additional headers such as "Reviewed-by"?
> 

The revised commit is enough. And you can add a "Reviewed-by".

- Andreas