[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

[James Zern]

On Thu, Jan 16, 2020 at 11:04 AM Wonkap Jang <wonkapjang at gmail.com> wrote:
>
> James,
>
> On Thu, Jan 16, 2020 at 10:58 AM Wonkap Jang <
> wonkap-at-google.com at ffmpeg.org> wrote:
>
> > This commit reuses the configuration options for VP8 that enables
> > temporal scalability for VP9. It also adds a way to enable three
> > preset temporal structures (refer to the documentation for more
> > detail) that can be used in offline encoding.
> > ---
> >  doc/encoders.texi      |  18 ++-
> >  libavcodec/libvpxenc.c | 252 +++++++++++++++++++++++++++++++++++++----
> >  2 files changed, 244 insertions(+), 26 deletions(-)
> >
> > [...]
> >
> > -static int vp8_ts_param_parse(struct vpx_codec_enc_cfg *enccfg, char
> > *key, char *value)
> > +static void set_temporal_layer_pattern(int layering_mode,
> > +                                       vpx_codec_enc_cfg_t *cfg,
> > +                                       int *layer_flags,
> > +                                       int *flag_periodicity)

you can join a couple of these lines like in the other function

> > +{
> > +    switch (layering_mode) {
> > +    case 2: {
> > +        /**
> > +         * 2-layers, 2-frame period.
> > +         */
> > +        int ids[2] = { 0, 1 };

make these static const int.