[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

[James Zern]

On Wed, Jan 15, 2020 at 6:20 PM Wonkap Jang
<wonkap-at-google.com at ffmpeg.org> wrote:
>
> HI,
> My comments are in-line.
>
> On Tue, Jan 14, 2020 at 8:55 PM James Zern <jzern-at-google.com at ffmpeg.org>
> wrote:
>
> > On Tue, Jan 14, 2020 at 11:07 AM Wonkap Jang
> > <wonkap-at-google.com at ffmpeg.org> wrote:
> > > [...]
> > > +
> > > +        /**
> > > +         * 0=L, 1=GF, 2=ARF,
> >
> > my point with the earlier comment was that you document 3 indices, but
> > set 4. if [3] won't be used in this case then the assignment could be
> > removed.
> >
> [WJ] the ids[] and layer_flags[] are indexed up to the frame# in
> ts_periodicity..
> so that goes from 0-3 (period of 4), whereas ts_rate_decimator[] is indexed
> by the temporal layer id itself (ids[]) which goes from 0 to 2. Am I
> missing something?
>

Maybe I am. I took 0=L, 1=GF, 2=ARF to be comments about the indices
and was wondering why 3 wasn't documented or whether it was needed.