[FFmpeg-devel] [PATCH 2/2] avcodec/wmalosslessdec: Replace negative channel check by assert

Michael Niedermayer michael at niedermayer.cc
Wed Jan 15 02:21:08 EET 2020


It is already checked by common code in git/master

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/wmalosslessdec.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c
index 2b97c2a848..cd7469405d 100644
--- a/libavcodec/wmalosslessdec.c
+++ b/libavcodec/wmalosslessdec.c
@@ -189,11 +189,8 @@ static av_cold int decode_init(AVCodecContext *avctx)
         return AVERROR(EINVAL);
     }
 
-    if (avctx->channels < 0) {
-        av_log(avctx, AV_LOG_ERROR, "invalid number of channels %d\n",
-               avctx->channels);
-        return AVERROR_INVALIDDATA;
-    } else if (avctx->channels > WMALL_MAX_CHANNELS) {
+    av_assert0(avctx->channels >= 0);
+    if (avctx->channels > WMALL_MAX_CHANNELS) {
         avpriv_request_sample(avctx,
                               "More than %d channels", WMALL_MAX_CHANNELS);
         return AVERROR_PATCHWELCOME;
-- 
2.24.0



More information about the ffmpeg-devel mailing list