[FFmpeg-devel] [PATCH v6 0/5] Fix mpeg1/2 stream copy

Gaullier Nicolas nicolas.gaullier at cji.paris
Tue Jan 14 00:42:33 EET 2020


>Apart from what Anton wrote, it appears to me that not all patches in the
>series are necessary to fix the stream-copying.
>
>Carl Eugen

Precisely:
- 1/2/3 are working together : actual code from ffmpeg.c that is used for stream encoding is now used for probing in libav, so it is "moved to public" and shared. But strictly speaking, 3 is not required to fix the stream-copying, it is only a "code simplification" = use the newly created public method.
- 4 is a bug fix that is necessary to apply before 5 to avoid generating duplicate side data (this does not prevent stream copy from working, but of course this is very bad), but maybe I should have indicated this in the commit msg
- 5 just add the coded side data that find_stream_info will forward to stream side data that ffmpeg will forward to output mux in case of stream copy.

Sorry, I have little experience in contributing to open projects and I think I tend to not document enough in the commit msgs

Nicolas


More information about the ffmpeg-devel mailing list