[FFmpeg-devel] [PATCH V1 04/11] lavfi/hue: enable runtime change flag

[Paul B Mahol]

On 1/11/20, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Sat, Jan 11, 2020 at 12:13:51PM +0800, Jun Zhao wrote:
>> From: Jun Zhao <barryjzhao at tencent.com>
>>
>> enable runtime change flag.
>>
>> Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
>> ---
>>  libavfilter/vf_hue.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/libavfilter/vf_hue.c b/libavfilter/vf_hue.c
>> index 323333b..026d4b6 100644
>> --- a/libavfilter/vf_hue.c
>> +++ b/libavfilter/vf_hue.c
>> @@ -86,7 +86,7 @@ typedef struct HueContext {
>>  } HueContext;
>>
>>  #define OFFSET(x) offsetof(HueContext, x)
>> -#define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
>> +#define FLAGS
>> AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_RUNTIME_PARAM
>
> its maybe confusing if FLAGS sometimes means what TFLAGS means elsewhere
> while there FLAGS has different meaning.
> Something consistent across filters would be better
>
> Thanks
>

I disagree.

> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Many things microsoft did are stupid, but not doing something just because
> microsoft did it is even more stupid. If everything ms did were stupid they
> would be bankrupt already.
>