[FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

[Philip Langdale]

On Wed, 8 Jan 2020 14:31:05 -0800
Josh Allmann <joshua.allmann at gmail.com> wrote:
> 
> Hi Phil,
> 
> Flushing and resumption is documented/supported in nvenc via
> NV_ENC_FLAGS_EOS, but I wasn't sure if this was a feature that
> ffmpeg's integration was intentionally designed for. But if you
> confirm we can expect this behavior to be supported going forward,
> then that's great news.

Yeah. There's nothing weird about this usage - it's just uncommon.
 
> 
> We do have internal tests [1]  that should catch the issue if anything
> changes, so that might be of some help as well, although we currently
> only update ffmpeg on an as-needed basis.
> 
> [1] https://github.com/livepeer/lpms/blob/master/ffmpeg/nvidia_test.go

That's good to know. Hopefully you'll let us know if anything breaks
down the line. :-)
 
> 
> Can confirm that this patch works very nicely in conjunction with
> avcodec_flush_buffers . Thanks so much!

Thanks. I've pushed it.

--phil