[FFmpeg-devel] [PATCH] Add advance vps/sps/pps id to hevc_metadata bsf

[Eran Gonen]

Advance pps id means advance pps id. What would you suggest?

On Wed, Jan 8, 2020 at 4:04 PM Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Wed, Jan 8, 2020 at 2:18 PM Eran Gonen <eran.gonen at cloudinary.com>
> wrote:
> > @@ -547,6 +642,16 @@ static const AVOption h265_metadata_options[] = {
> >          OFFSET(crop_bottom), AV_OPT_TYPE_INT,
> >          { .i64 = -1 }, -1, HEVC_MAX_HEIGHT, FLAGS },
> >
> > +    { "advance_vps_id", "Advance the vps id",
> > +        OFFSET(advance_vps_id), AV_OPT_TYPE_INT,
> > +        { .i64 = -1 }, -1, HEVC_MAX_VPS_COUNT, FLAGS },
> > +    {  "advance_sps_id", "Advance the sps id",
> > +        OFFSET(advance_sps_id), AV_OPT_TYPE_INT,
> > +        { .i64 = -1 }, -1, HEVC_MAX_SPS_COUNT, FLAGS },
> > +    {  "advance_pps_id", "Advance the pps id",
> > +        OFFSET(advance_pps_id), AV_OPT_TYPE_INT,
> > +        { .i64 = -1 }, -1, HEVC_MAX_PPS_COUNT, FLAGS },
> > +
>
> I think these could use some better wording and/or documentation, I'm
> not sure many people would understand whats going to happen here.
>
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".