[FFmpeg-devel] [PATCH] CDToons decoder

Alyssa Milburn amilburn at zall.org
Mon Jan 6 22:01:38 EET 2020


On Sun, Jan 05, 2020 at 07:37:06PM -0300, James Almer wrote:
> > + * Copyright (C) 2011 The FFmpeg project
> 
> 2011?

This patch has been lying around for a while. :/ Will update to 2020.

> Use av_fast_malloc() instead of constantly freeing and reallocating
> these buffers. See libavutil/mem.h

Sprites are typically only allocated once for a given sprite_id, so for most
situations the only difference would be to delay deallocation until the end
of the video. Do you think it's worth doing anyway? (Easy enough to do.)

Otherwise: ACK, thank you for the fast review.

- Alyssa


More information about the ffmpeg-devel mailing list