[FFmpeg-devel] [PATCH v1] avfilter/af_amix: change the max range of the number of inputs

[Paul B Mahol]

On 1/6/20, Limin Wang <lance.lmwang at gmail.com> wrote:
> On Mon, Jan 06, 2020 at 01:28:45PM +0100, Paul B Mahol wrote:
>> Limit is not real, its too big.
>
> So what's reasonable value to use?
> I notice video mix choose INT_MAX, so I use the same.

INT16_MAX seems high enough.

>
> [lmwang at vpn ffmpeg]$ grep nb_inputs libavfilter/vf_mix.c |grep INT_MAX
>     { "inputs", "set number of inputs", OFFSET(nb_inputs), AV_OPT_TYPE_INT,
> {.i64=2}, 2, INT_MAX, .flags = FLAGS },
>
>>
>> On 1/6/20, lance.lmwang at gmail.com <lance.lmwang at gmail.com> wrote:
>> > From: Limin Wang <lance.lmwang at gmail.com>
>> >
>> > Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
>> > ---
>> >  libavfilter/af_amix.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c
>> > index 89a1b0568f..1e1753b078 100644
>> > --- a/libavfilter/af_amix.c
>> > +++ b/libavfilter/af_amix.c
>> > @@ -182,7 +182,7 @@ typedef struct MixContext {
>> >  #define F AV_OPT_FLAG_FILTERING_PARAM
>> >  static const AVOption amix_options[] = {
>> >      { "inputs", "Number of inputs.",
>> > -            OFFSET(nb_inputs), AV_OPT_TYPE_INT, { .i64 = 2 }, 1, 1024,
>> > A|F
>> > },
>> > +            OFFSET(nb_inputs), AV_OPT_TYPE_INT, { .i64 = 2 }, 1,
>> > INT_MAX,
>> > A|F },
>> >      { "duration", "How to determine the end-of-stream.",
>> >              OFFSET(duration_mode), AV_OPT_TYPE_INT, { .i64 =
>> > DURATION_LONGEST }, 0,  2, A|F, "duration" },
>> >          { "longest",  "Duration of longest input.",  0,
>> > AV_OPT_TYPE_CONST,
>> > { .i64 = DURATION_LONGEST  }, 0, 0, A|F, "duration" },
>> > --
>> > 2.21.0
>> >
>> > _______________________________________________
>> > ffmpeg-devel mailing list
>> > ffmpeg-devel at ffmpeg.org
>> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >
>> > To unsubscribe, visit link above, or email
>> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>
> --
> Thanks,
> Limin Wang
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".